Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage remote servers infos #32

Merged
merged 7 commits into from
Feb 21, 2022
Merged

Manage remote servers infos #32

merged 7 commits into from
Feb 21, 2022

Conversation

relf
Copy link
Collaborator

@relf relf commented Feb 21, 2022

This PR refactors the management of login infos.

  • Now wop stores remote servers (a.k.a remotes) login infos (when successful). For instance, after a successful login sequence with wop login https://remote.example.com and API key input, further required login to this url will be simply done automatically with wop login remote.
  • New command options:
    • wop list/logout -r: lists known remotes.
    • wop logout -r <name>: remove remote info specified by its name.
    • wop logout --all: remove all remotes infos.
  • API change:
    • whatsopt_client.WhatsOpt(): login keyword argument is deprecated.
      WhatsOpt(login=False) should be replaced by WhatsOpt() with further wop versions.
  • Breaking changes:
    • Now WhatsOpt() does not "log in" automatically:
      • WhatsOpt() or WhatsOpt(login=True) has to be replaced by WhatsOpt.login()
    • Remove PROD_URL, INTRANET_SERVER_URL constants
    • Remove default_url property

That leads to major version bump 2.0 (still in beta though... besides further testing, 2.0 may embark other features).

@relf relf merged commit 360f820 into whatsopt:master Feb 21, 2022
@relf relf deleted the ft-remote branch February 21, 2022 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant