fixed managment of optimizations #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relf
requested changes
Aug 19, 2022
| def new | ||
| @optimization = Optimization.new | ||
| authorize @optimization | ||
| optim_num = Optimization.owned_by(current_user).size | ||
| if optim_num > 19 |
There was a problem hiding this comment.
Avoid the magic-number effect by using a constant MAX_OPTIM_NUMBER = 20 (is it not 20 for allowing 20 optims?). Ideally this constant should be defined in Optimization class as it has to be used also in the api\v1\optimization_controller.rb. By the way, could you also implement the optim limit in that file for the JSON REST api? May be you can even add a test for this: create 20 optims and check for an error when trying to create the 21fst.
| def new | ||
| @optimization = Optimization.new | ||
| authorize @optimization | ||
| optim_num = Optimization.owned_by(current_user).size | ||
| if optim_num > 19 | ||
| redirect_to optimizations_url, notice: "You own too many optimizations (#{optim_num}), you must delete some before creating new ones" |
There was a problem hiding this comment.
I think you can use alert: instead of notice:, it changes the flash message color.
| if File.exist?(path) | ||
| send_file(path) | ||
| else | ||
| redirect_to optimization_path(optim), notice: "There isn't a log file" |
| end | ||
| end | ||
| if errors != "" | ||
| redirect_to edit_optimization_path(@optimization), notice: "Optimization update failed, #{errors}" |
There was a problem hiding this comment.
here and just below alert: instead of notice:
relf
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.