Skip to content

Commit

Permalink
fix: upgradeing to websocket caused server crashed (closes chimurai#777)
Browse files Browse the repository at this point in the history
  • Loading branch information
whatwewant committed May 9, 2022
1 parent 03239c7 commit 9fbcc12
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion src/http-proxy-middleware.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,15 @@ import * as PathRewriter from './path-rewriter';
import * as Router from './router';
import { Debug as debug } from './debug';
import { getFunctionName } from './utils/function';
import { getLogger } from './logger';

export class HttpProxyMiddleware {
private wsInternalSubscribed = false;
private serverOnCloseSubscribed = false;
private proxyOptions: Options;
private proxy: httpProxy;
private pathRewriter;
private logger = getLogger({ logger: console });

constructor(options: Options) {
verifyConfig(options);
Expand Down Expand Up @@ -95,7 +97,10 @@ export class HttpProxyMiddleware {
private handleUpgrade = async (req: Request, socket, head) => {
if (this.shouldProxy(this.proxyOptions.pathFilter, req)) {
const activeProxyOptions = await this.prepareProxyRequest(req);
this.proxy.ws(req, socket, head, activeProxyOptions);
this.proxy.ws(req, socket, head, activeProxyOptions, (err, req, socket) => {
this.logger.error('[HPM] Upgrading to WebSocket Error:', err, req, socket);
});

debug('server upgrade event received. Proxying WebSocket');
}
};
Expand Down

0 comments on commit 9fbcc12

Please sign in to comment.