Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -webkit-line-clamp #105

Closed
annevk opened this issue Sep 12, 2018 · 4 comments
Closed

Add -webkit-line-clamp #105

annevk opened this issue Sep 12, 2018 · 4 comments

Comments

@annevk
Copy link
Member

annevk commented Sep 12, 2018

Per https://bugzilla.mozilla.org/show_bug.cgi?id=866102 Edge has already added it and there seems increasing pressure on Firefox to add it too. 😟

cc @RByers

@domenic
Copy link
Member

domenic commented Sep 12, 2018

Per https://bugzilla.mozilla.org/show_bug.cgi?id=866102#c12 this seems like another case, like -webkit-appearance, where there's an ideal version that CSSWG editors would prefer, and there's the version that everyone is being forced to implement for web compat. Not sure what to do there.

https://bugzilla.mozilla.org/show_bug.cgi?id=866102#c23 and https://bugzilla.mozilla.org/show_bug.cgi?id=866102#c28 implies Mozilla might be interested in trying the CSSWG version first at least.

@miketaylr
Copy link
Member

From @heycam (in Comment 29)

Once we have an implementation of the standards version we can look at whether we really need to implement the oddities of -webkit-line-clamp.

If and when we implement the standard version, I'd recommend we at least do some testing to see if aliasing -webkit-line-clamp will work for most existing usage. Getting sites to remove prefixes is pretty much a lost cause.

@heycam
Copy link
Contributor

heycam commented Mar 1, 2019

-webkit-line-clamp is now defined in css-overflow-3.

https://drafts.csswg.org/css-overflow-3/#webkit-line-clamp

So I think this issue can be closed.

@annevk annevk closed this as completed Mar 1, 2019
@miketaylr
Copy link
Member

nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants