Skip to content

Commit

Permalink
Define remainder of insertAdjacentElement()
Browse files Browse the repository at this point in the history
It needs to actually return something and rethrow exceptions in all
cases.

Also add a note to indicate insertAdjacentText() does not return
anything.

Per feedback from Olli on #whatwg IRC.
  • Loading branch information
annevk committed Mar 30, 2016
1 parent 10b6cf1 commit 5790d72
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 32 deletions.
19 changes: 11 additions & 8 deletions dom.bs
Original file line number Diff line number Diff line change
Expand Up @@ -5586,7 +5586,7 @@ steps:
<li><p>Let <var>qualifiedName</var> be <a>context object</a>'s <a for=Element>qualified name</a>.

<li><p>If the <a>context object</a> is in the <a>HTML namespace</a> and its <a>node document</a> is
an <a>HTML document</a>, let <var>qualifiedName</var> be <span>converted to ASCII uppercase</span>.
an <a>HTML document</a>, let <var>qualifiedName</var> be <a>converted to ASCII uppercase</a>.

<li>Return <var>qualifiedName</var>.
</ol>
Expand Down Expand Up @@ -5930,22 +5930,23 @@ for the <a>context object</a>.
<dd>
<p>If <var>element</var>'s <a>parent</a> is null, return null.

<p><a for=Node>Pre-insert</a> <var>node</var> into <var>element</var>'s <a>parent</a> before
<var>element</var>. Rethrow any exceptions.
<p>Return the result of <a for=Node>pre-inserting</a> <var>node</var> into <var>element</var>'s
<a>parent</a> before <var>element</var>. Rethrow any exceptions.

<dt>"<code>afterbegin</code>"
<dd><p><a for=Node>Pre-insert</a> <var>node</var> into <var>element</var> before
<var>element</var>'s <a for=tree>first child</a>.
<dd><p>Return the result of <a for=Node>pre-inserting</a> <var>node</var> into <var>element</var>
before <var>element</var>'s <a for=tree>first child</a>. Rethrow any exceptions.

<dt>"<code>beforeend</code>"
<dd><p><a for=Node>Pre-insert</a> <var>node</var> into <var>element</var> before null.
<dd><p>Return the result of <a for=Node>pre-inserting</a> <var>node</var> into <var>element</var>
before null. Rethrow any exceptions.

<dt>"<code>afterend</code>"
<dd>
<p>If <var>element</var>'s <a>parent</a> is null, return null.

<p><a for=Node>Pre-insert</a> <var>node</var> into <var>element</var>'s <a>parent</a> before
<var>element</var>'s <a for=tree>next sibling</a>. Rethrow any exceptions.
<p>Return the result of <a for=Node>pre-inserting</a> <var>node</var> into <var>element</var>'s
<a>parent</a> before <var>element</var>'s <a for=tree>next sibling</a>. Rethrow any exceptions.

<dt>Otherwise</dt>
<dd><p>Throw a {{SyntaxError}} exception.
Expand All @@ -5967,6 +5968,8 @@ method, when invoked, must run these steps:
<var>text</var>. Rethrow any exceptions.
</ol>

<p class="note">This method returns nothing because it existed before we had a chance to design it.


<h4 id='interface-namednodemap'>Interface {{NamedNodeMap}}</h4>

Expand Down

0 comments on commit 5790d72

Please sign in to comment.