Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This is the first part of upstreaming custom elements into the DOM and HTML Standards, instead of having them be in a separate spec that is essentially a bunch of monkeypatches. The second part will be upstreaming the remaining portions into HTML. See https://rawgit.com/w3c/webcomponents/15a203c8393aef0df7223ab1d43406aa11a7e71e/spec/custom/index.html for the source material, in particular the sections labeled "DOM+". Some minor bugs were fixed while upstreaming, mainly in the "remove" algorithm for elements. The rest of the changes were editorial.
- Loading branch information
7f63535There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @domenic , do you plan to acknowledge somewhere where this addition was derived from?
7f63535There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For sure! Did you see line 9712, and also the commit message?
7f63535There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed it indeed. Thank you.
7f63535There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm missing
optionsargument directly in def:https://dom.spec.whatwg.org/#dom-document-createelement
https://dom.spec.whatwg.org/#dom-document-createelementns
DOM spec always pass such optional argument in def and other WHATWG spec too (only HTML is inconsistent here).
7f63535There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, can you open an issue instead of commenting on the commit?
7f63535There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll fix that, but yeah, it'd be great if you could file issues @ArkadiuszMichalski or comment on the PR while it's in progress. Whenever you comment on a commit it puts pressure on those maintaining the repository. They either have to take action straight away in some fashion or ignore your comment (or hope to remember it, but that seems less likely).
7f63535There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2168da2
Thanks.