Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undefined variable in the "add an event listener" algorithm #1203

Closed
jeremydavis519 opened this issue May 27, 2023 · 1 comment · Fixed by #1204
Closed

Undefined variable in the "add an event listener" algorithm #1203

jeremydavis519 opened this issue May 27, 2023 · 1 comment · Fixed by #1204

Comments

@jeremydavis519
Copy link

https://dom.spec.whatwg.org/commit-snapshots/86022424b865fa50ade8a90825b47a0012a16ae0/#add-an-event-listener

If listener’s passive is null, then set it to the default passive value given type and eventTarget.

This is a very minor issue, but it also looks very easy to fix. Step 4 of the algorithm to add an event listener refers to a variable called type, but that variable doesn't exist. Unless I've missed something, this is supposed to say "listener's type".
annevk added a commit that referenced this issue May 30, 2023
@annevk
Correct undefined variable in add an event listener
96d4f29 
Also add <div algorithm> wrappers to make this problem less likely to reoccur in this section.

Fixes #1203.
@annevk annevk mentioned this issue May 30, 2023
Merged
@annevk
Copy link
Member

annevk commented May 30, 2023

Thanks: #1204.

annevk added a commit that referenced this issue May 31, 2023
@annevk
Correct undefined variable in add/remove an event listener
451dae2 
Also add <div algorithm> wrappers to make this problem less likely to reoccur in this section.

Fixes #1203.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correct undefined variable in add an event listener whatwg/dom
2 participants
@annevk @jeremydavis519