Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abstract common logic in toggleAttribute() and setAttribute()? #657

Open
annevk opened this issue Jun 21, 2018 · 1 comment
Open

Abstract common logic in toggleAttribute() and setAttribute()? #657

annevk opened this issue Jun 21, 2018 · 1 comment
Labels
clarification Standard could be clearer

Comments

@annevk
Copy link
Member

annevk commented Jun 21, 2018

In particular for creating a new attribute and appending it. If we don't create an abstraction, we should at least improve the language.
@annevk annevk added the clarification Standard could be clearer label Jun 21, 2018
@jonathanKingston
Copy link
Contributor

I'm interested in moving that out.

This was referenced Jun 28, 2018
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
clarification Standard could be clearer
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonathanKingston @annevk