Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add abort reason to AbortSignal #1027

Merged
merged 20 commits into from
Nov 8, 2021
Merged

Add abort reason to AbortSignal #1027

merged 20 commits into from
Nov 8, 2021

Commits on Oct 18, 2021

  1. add abort reason to AbortSignal and Controller

    @nidhijaju
    nidhijaju committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    e18e130 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2021

  1. address comments

    @nidhijaju
    nidhijaju committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    9fd1583 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2021

  1. pass reason to signal abort

    @nidhijaju
    nidhijaju committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    74a1f2f View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2021

  1. add reason to static abort & fix description

    @nidhijaju
    nidhijaju committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    6a10478 View commit details
    Browse the repository at this point in the history

  2. make small fixes

    @nidhijaju
    nidhijaju committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    e2d5792 View commit details
    Browse the repository at this point in the history

  3. remove undefined & combine reason assignment steps

    @nidhijaju
    nidhijaju committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    8fbd339 View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: Anne van Kesteren <annevk@annevk.nl>
    @nidhijaju @annevk
    nidhijaju and annevk committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    a213031 View commit details
    Browse the repository at this point in the history

  5. add <var>

    @nidhijaju
    nidhijaju committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    0eaaf51 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2021

  1. address comments

    @nidhijaju
    nidhijaju committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    03f41be View commit details
    Browse the repository at this point in the history

  2. add name to acknowledgements

    @nidhijaju
    nidhijaju committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    a10677a View commit details
    Browse the repository at this point in the history

  3. remove empty line in AbortSignal interface 

    Co-authored-by: Anne van Kesteren <annevk@annevk.nl>
    @nidhijaju @annevk
    nidhijaju and annevk committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    239e094 View commit details
    Browse the repository at this point in the history

  4. move signal.reason below aborted

    @nidhijaju
    nidhijaju committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    c6297b8 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2021

  1. add abort reason assertion to signal abort

    @nidhijaju
    nidhijaju committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    fa2dd31 View commit details
    Browse the repository at this point in the history

  2. remove aborted flag

    @nidhijaju
    nidhijaju committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    98dcce7 View commit details
    Browse the repository at this point in the history

  3. remove assert

    @nidhijaju
    nidhijaju committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    a321593 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2021

  1. add aborted predicate

    @nidhijaju
    nidhijaju committed Oct 29, 2021
    Configuration menu
    Copy the full SHA
    e469279 View commit details
    Browse the repository at this point in the history

  2. use predicate in more places

    @nidhijaju
    nidhijaju committed Oct 29, 2021
    Configuration menu
    Copy the full SHA
    c102cd8 View commit details
    Browse the repository at this point in the history

  3. fix reason var

    @nidhijaju
    nidhijaju committed Oct 29, 2021
    Configuration menu
    Copy the full SHA
    dbbfeb6 View commit details
    Browse the repository at this point in the history

  4. also update the "how to use" section

    @annevk
    annevk committed Oct 29, 2021
    Configuration menu
    Copy the full SHA
    330c5d7 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2021

  1. nits

    @annevk
    annevk committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    723f5e8 View commit details
    Browse the repository at this point in the history