Add a validation step when a new DOMTokenList is created #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -8642,8 +8642,10 @@ are to: | |||
| <a lt="named attribute"><var>associated attribute's local name</var> attribute</a> or | |||
| associated <a for="/">element</a>'s | |||
| <a lt="named attribute"><var>associated attribute's local name</var> attribute</a> is | |||
| <a lt="attribute is set">set</a>, set <a>tokens</a> to the new <a for=Attr>value</a>, | |||
| <a lt="ordered set parser">parsed</a>. | |||
| <a lt="attribute is set">set</a>, let <var>temporary tokens</var> be the new <a for=Attr>value</a>, | |||
There was a problem hiding this comment.
I would prefer a "run these substeps" if we start creating variables. I think that would be a little easier to read.
|
Fixed the issues raised in comments |
| @@ -8606,7 +8606,7 @@ associated <a>attribute</a>'s <a for=Attr>local name</a>. | |||
| <var>token</var> are: | |||
|
|
|||
| <ol> | |||
| <li><p>If the associated attribute's <a for=Attr>local name</a> does not define <a>supported | |||
| <li><p>If the associated <a>attribute</a>'s <a for=Attr>local name</a> does not define <a>supported | |||
| tokens</a>, return true. | |||
There was a problem hiding this comment.
Last nit, no breaking inside of a single element. (HTML does it, but try to avoid it as it makes search & replace harder than it needs to be.)
With that fixed, if you rebase/squash, I'll land this.
This fixes multiple issues introduced when adding validation to DOMTokenList: * When a new DOMTokenList object is created, we now validate each token. * IDL definition of `add()` was fixed to reflect returning a boolean. * A reference was added to "attribute" in a place where one was missing.
yoavweiss
force-pushed
the
validate_incoming_attributeset
branch
from
5829f19
to
63a0302
Compare
|
Fixed and squashed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #106
@annevk - I added a validation step to the DOMTokenList creation. Can you take a look?