Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

createEvent("textevent") creates a TextEvent #1254

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

zcorpan
Copy link
Member

@zcorpan zcorpan commented Feb 8, 2024

See w3c/uievents#362

(See WHATWG Working Mode: Changes for more details.)


Preview | Diff

@zcorpan
Copy link
Member Author

zcorpan commented Feb 8, 2024

I think w3c/uievents#362 needs to land first to make this build without errors.

@annevk
Copy link
Member

annevk commented Feb 8, 2024

Can you write a paragraph or so about the context? The UI Events issue is very light on details.

@zcorpan
Copy link
Member Author

zcorpan commented Feb 9, 2024

The textInput event is required for web compat when typing, pasting, dropping, and maybe some other actions, in an editable field (input or textarea or contenteditable). The event uses the TextEvent interface in Chromium and WebKit. Supporting that interface and the change in this PR is also required for web compat because some sites use it for feature-checking support for the textInput event. Example: https://github.com/cespare/pastedown/blob/9211a49c848d037b01fd42c26891f4b83a19a56d/public/pastedown.js#L51

@zcorpan
Copy link
Member Author

zcorpan commented Feb 9, 2024

@zcorpan zcorpan force-pushed the zcorpan/createEvent-textevent branch from 7ec1945 to fba814b Compare February 23, 2024 11:46
@zcorpan
Copy link
Member Author

zcorpan commented Feb 23, 2024

I think w3c/uievents#362 needs to land first to make this build without errors.

That has now landed and the build check for this PR is now green.

@annevk annevk merged commit 6a9b5a2 into main Feb 23, 2024
2 checks passed
@annevk annevk deleted the zcorpan/createEvent-textevent branch February 23, 2024 12:07
zcorpan added a commit to web-platform-tests/wpt that referenced this pull request Feb 23, 2024
marcoscaceres pushed a commit to web-platform-tests/wpt that referenced this pull request Feb 23, 2024
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Mar 2, 2024
…aps to TextEvent, a=testonly

Automatic update from web-platform-tests
DOM: document.createEvent('textevent') maps to TextEvent

See whatwg/dom#1254

--

wpt-commits: 6c0e7075b4387cee6679db3ebec4e4be3bac2f86
wpt-pr: 44467
jamienicol pushed a commit to jamienicol/gecko that referenced this pull request Mar 4, 2024
…aps to TextEvent, a=testonly

Automatic update from web-platform-tests
DOM: document.createEvent('textevent') maps to TextEvent

See whatwg/dom#1254

--

wpt-commits: 6c0e7075b4387cee6679db3ebec4e4be3bac2f86
wpt-pr: 44467
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants