Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record timing info for event handling. #1267

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Record timing info for event handling. #1267

merged 3 commits into from
Apr 16, 2024

Conversation

noamr
Copy link
Collaborator

@noamr noamr commented Mar 27, 2024

This feeds into "Long Animation Frame" timing.

(See WHATWG Working Mode: Changes for more details.)


Preview | Diff

This feeds into "Long Animation Frame" timing.
@annevk
Copy link
Member

annevk commented Apr 9, 2024

Why is it called "event handler" when you're in fact creating something for each listener? Event handlers and event listeners are distinct.

@noamr
Copy link
Collaborator Author

noamr commented Apr 9, 2024

Why is it called "event handler" when you're in fact creating something for each listener? Event handlers and event listeners are distinct.

Good point, will rename this.

@noamr
Copy link
Collaborator Author

noamr commented Apr 9, 2024

Why is it called "event handler" when you're in fact creating something for each listener? Event handlers and event listeners are distinct.

Good point, will rename this.

Renamed, though would need to wait for the refs to update before this builds successfully.

@noamr noamr closed this Apr 9, 2024
@noamr noamr reopened this Apr 9, 2024
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this should happen after setting event's in passive listener flag. At least it seems the intent is that this happens close to actually calling the callback and where it is placed now it seems like it could easily move further away from that.

You'll have the duplicate global conditional, but seems acceptable?

@noamr
Copy link
Collaborator Author

noamr commented Apr 15, 2024

I wonder if this should happen after setting event's in passive listener flag. At least it seems the intent is that this happens close to actually calling the callback and where it is placed now it seems like it could easily move further away from that.

You'll have the duplicate global conditional, but seems acceptable?

Yes, that's ok

@noamr
Copy link
Collaborator Author

noamr commented Apr 15, 2024

I wonder if this should happen after setting event's in passive listener flag. At least it seems the intent is that this happens close to actually calling the callback and where it is placed now it seems like it could easily move further away from that.
You'll have the duplicate global conditional, but seems acceptable?

Yes, that's ok

Done

@annevk annevk merged commit 77cd75e into whatwg:main Apr 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants