-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Record timing info for event handling. #1267
Conversation
This feeds into "Long Animation Frame" timing.
Why is it called "event handler" when you're in fact creating something for each listener? Event handlers and event listeners are distinct. |
Good point, will rename this. |
Renamed, though would need to wait for the refs to update before this builds successfully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this should happen after setting event's in passive listener flag. At least it seems the intent is that this happens close to actually calling the callback and where it is placed now it seems like it could easily move further away from that.
You'll have the duplicate global conditional, but seems acceptable?
Yes, that's ok |
Done |
This feeds into "Long Animation Frame" timing.
(See WHATWG Working Mode: Changes for more details.)
Preview | Diff