Properly check event's stop immediate propagation flag in "inner invoke" #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How did you avoid the fatal error? |
|
We should probably point out that this fixes a regression caused by 1cce4fd. |
I removed the wolf bits, then resetted the corresponding change in |
nox
force-pushed
the
invoke-inner-stop-immediate
branch
from
8cf1914
to
07a2a92
Compare
|
I added a reference to 1cce4fd in the message. |
|
I see, I think I'll wait for @tabatkins to fix bikeshed to not result in a FATAL ERROR before landing this. |
This fixes a regression introduced in 1cce4fd.
nox
force-pushed
the
invoke-inner-stop-immediate
branch
from
07a2a92
to
604a78b
Compare
|
I used speced/bikeshed#611 and updated the spec with it, though I now realise this PR doesn't pass the tests. :( |
|
What tests? |
|
I mean the Bikeshed one. See the build log. |
|
Now speced/bikeshed#609 is not making me happy. Going to postpone this a little longer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.