Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix another NodeIterator removing step #27

Closed
wants to merge 1 commit into from
Closed

Fix another NodeIterator removing step #27

wants to merge 1 commit into from

Conversation

Joris-van-der-Wel
Copy link
Contributor

This change makes it more consistent with the other rules. Also,
it is what the w3c test suite expects and how the browsers behave.

Here's a quick snippit to test:

document.body.innerHTML = "<p>Efghijkl</p><p>Mnopqrst</p>";
var it = document.createNodeIterator(document);
while (it.nextNode());

var removed = document.body.children[1];
removed.parentNode.removeChild(removed);

console.info(it.referenceNode === document.body.children[0].lastChild);
console.info(it.pointerBeforeReferenceNode === false);

This change makes it more consistent with the other rules. Also,
it is what the w3c test suite expects and how the browsers behave.
@annevk
Copy link
Member

annevk commented Apr 22, 2015

So if I want to integrate this and preserve authorship I need your email address...

@annevk annevk closed this in 248d4fe Apr 22, 2015
@domenic
Copy link
Member

domenic commented Apr 22, 2015

I always use .patch URLs for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants