Reinstate CDATASection #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1488,7 +1488,7 @@ can be used to explore this matter in more detail. | |||
|
|
|||
| <h3 id=node-trees>Node tree</h3> | |||
|
|
|||
| <p>{{Document}}, {{DocumentType}}, {{DocumentFragment}}, {{ShadowRoot}}, {{Element}}, {{Text}}, | |||
There was a problem hiding this comment.
Mind splitting the ShadowRoot changes into a separate commit for landing? Same PR is fine, I'll merge the sum of it now.
There was a problem hiding this comment.
Yeah I can do that, provided the ShadowRoot changes look fine.
|
OK, I've reviewed and compared to Blink, all LGTM! Matching Blink CL: https://codereview.chromium.org/2249083002 |
I’m thirty now so it’s time to face reality. This fixes https://www.w3.org/Bugs/Public/show_bug.cgi?id=27386.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’m thirty now so it’s time to face reality. This fixes
https://www.w3.org/Bugs/Public/show_bug.cgi?id=27386. This also closes
#190 by deciding to not enumerate subclasses of concrete (non-abstract)
interfaces (ShadowRoot and CDATASection in particular).