Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop defining nodeName in terms of tagName #593

Merged
merged 2 commits into from Mar 13, 2018
Merged

Stop defining nodeName in terms of tagName #593

merged 2 commits into from Mar 13, 2018

Conversation

annevk
Copy link
Member

@annevk annevk commented Mar 13, 2018 •
edited by pr-preview bot

Fixes #297.

Preview | Diff

@domenic
Copy link
Member

domenic commented Mar 13, 2018

Maybe "HTML-uppercased qualified name"?

@annevk
Copy link
Member Author

annevk commented Mar 13, 2018

I guess that's fine. I kinda like blurred since you lose information with something like createElementNS(HTML_NS, "tT:p"). Indicates it's a somewhat bad API.

@domenic
Copy link
Member

domenic commented Mar 13, 2018

If you added that in a note I'd totally support blurred :)

@annevk
Copy link
Member Author

annevk commented Mar 13, 2018

Considering it more I'll go with your version since there's way too many nuances here. At some point we should maybe explain the problems with the namespaced stuff, but not today.

@annevk annevk merged commit 8e754b5 into master Mar 13, 2018
@annevk annevk deleted the annevk/blurred-qualified-name branch March 13, 2018 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@annevk @domenic