Fix TreeWalker's nextNode() #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The prose supposed to be equivalent to iterating over following siblings and siblings of ancestors did not skip over descendants. See #87 (comment).
|
@triple-underscore thanks for reporting this. I didn't make it check for result being FILTER_REJECT is FILTER_SKIP is already handled by the earlier algorithm that goes through children. |
|
(I also worked out the prose that would just do the next sibling / parent traversal, but it ends up adding a significant number of steps and I'm not sure it's really any clearer.) |
|
Looking at https://www.w3.org/Bugs/Public/show_bug.cgi?id=28107 again I went with the longer algorithm after all since "following root" was also wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prose supposed to be equivalent to iterating over following siblings and siblings of ancestors did not skip over descendants.
See #87 (comment).
Preview | Diff