Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make createAttribute() lowercase the input in HTML documents #75

Closed
wants to merge 1 commit into from
Closed

Make createAttribute() lowercase the input in HTML documents #75

wants to merge 1 commit into from

Conversation

foolip
Copy link
Member

@foolip foolip commented Sep 17, 2015

Fixes #41

@foolip
Copy link
Member Author

foolip commented Sep 17, 2015

PTAL. I'm not sure if the argument name should be changed now that it isn't necessarily the verbatim localName, I just left it alone.

@annevk
Copy link
Member

annevk commented Sep 17, 2015

Oh I completely missed this. So Gecko now implements this simple behavior and Chrome does too?

@foolip
Copy link
Member Author

foolip commented Sep 17, 2015

No, it hasn't been implemented yet, but based on the use counters I added in Blink and the telemetry in Gecko, we seem to have agreed that this is the approach we should try. See https://bugzilla.mozilla.org/show_bug.cgi?id=1176313

@foolip
Copy link
Member Author

foolip commented Sep 17, 2015

If you want to wait with the spec change until it's been shipped, that's fine, it's just not the usual order.

@foolip
Copy link
Member Author

foolip commented Sep 21, 2015

@bzbarsky, are you now attempting to implement what the spec says plus the change in this PR in Gecko, or what is the whole "package" or changes being attempted at the same time?

@bzbarsky
Copy link

@foolip I've landed the change in this PR in Gecko nightlies. See https://bugzilla.mozilla.org/show_bug.cgi?id=1205364

I'm also attempting to reland the rest of the "follow the spec" changes; that's being tracked in https://bugzilla.mozilla.org/show_bug.cgi?id=1176313 and I expect to check it in sometime today.

@annevk annevk closed this Sep 22, 2015
@foolip foolip deleted the createAttribute-lowercase branch September 22, 2015 07:48
@foolip
Copy link
Member Author

foolip commented Sep 22, 2015

That sounds great, @bzbarsky! If those changes make it successfully to Firefox stable, I'd like to attempt the same spec sync in Blink.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants