Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align with IDL dictionary changes #771

Merged
merged 2 commits into from
Aug 8, 2019
Merged

Align with IDL dictionary changes #771

merged 2 commits into from
Aug 8, 2019

Conversation

annevk
Copy link
Member

@annevk annevk commented Jul 1, 2019 •
edited by pr-preview bot
Loading

@annevk annevk added the do not merge yet Pull request must not be merged per rationale in comment label Jul 1, 2019
@annevk annevk mentioned this pull request Jul 1, 2019
Merged
@CYBAI CYBAI mentioned this pull request Jul 4, 2019
Closed
@bzbarsky bzbarsky mentioned this pull request Jul 11, 2019
Closed
56 tasks
@annevk annevk removed the do not merge yet Pull request must not be merged per rationale in comment label Aug 8, 2019
@annevk annevk merged commit c15e65f into master Aug 8, 2019
@annevk annevk deleted the annevk/idl-dictionary branch August 8, 2019 15:54
@bzbarsky
Copy link

bzbarsky commented Aug 8, 2019 •
edited
Loading

@annevk The IDL for attachShadow here was correct before. The dictionary has a required member, so it's not required to be optional per the IDL spec (and in fact not passing it would always throw, so there's no reason to pretend like that's a thing someone would ever try to do).

@annevk
Copy link
Member Author

annevk commented Aug 9, 2019 •
edited
Loading

Yeah, my bad. I'll revert that part in #775.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@annevk @bzbarsky