Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TextEncoderStream and TextDecoderStream transform streams #149

Merged
merged 18 commits into from Aug 29, 2018
Merged

Add TextEncoderStream and TextDecoderStream transform streams #149

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
2756504
Add TextEncoderStream and TextDecoderStream transform streams
ricea Jul 13, 2018
886d920
General fixes
ricea Aug 3, 2018
3b912b3
Make FooAttributes mixins fully own their "slots"
ricea Aug 3, 2018
f04369c
Add "this object's" in three places
ricea Aug 3, 2018
6a65ad5
Make TextDecoderStream accept ArrayBufferView types
ricea Aug 7, 2018
343e148
Never enqueue an empty chunk
ricea Aug 7, 2018
6623b0b
Share the "serialize stream" algorithm
ricea Aug 7, 2018
0e64bf8
Use WebIDL to convert chunks for decoding to BufferSource
ricea Aug 8, 2018
407d85d
Translate exceptions from "copy bytes" into rejections
ricea Aug 8, 2018
60854d8
Add missing period.
ricea Aug 8, 2018
e5b36e1
address various nits
annevk Aug 8, 2018
12b5161
Remove no-longer-needed ECMASCRIPT refs section
ricea Aug 9, 2018
dd65b39
Add one missing word "object"
ricea Aug 9, 2018
66aaab3
Add Mattias Buelens to the acknowledgements
ricea Aug 9, 2018
af33687
Add ids to dfns that have moved to TextXcoderCommon
ricea Aug 9, 2018
29fdba4
formatting nits
annevk Aug 10, 2018
256a138
TextDecoderStream should not have decode()
annevk Aug 10, 2018
b9dfb01
more nits
annevk Aug 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion encoding.bs
View file
Open in desktop
Expand Up @@ -1486,7 +1486,7 @@ byteReadable

<li><p><a>Push</a> a <a lt="get a copy of the buffer source">copy of</a> <var>bufferSource</var> to
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In 6a65ad5, we explicitly checked for IsDetachedBuffer(arrayBuffer) and returned a rejected promise if the buffer was detached. However, none of the three algorithms that make up convert to a BufferSource check for detached buffers.

When get a copy of the buffer source encounters a detached buffer, it throws a TypeError in step 7. This is not what we want: we want to return a rejected promise instead!

I think the easiest fix would be to add the following line to this step, similar to the previous step:

If this throws an exception, then return a promise rejected with that exception.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks.

I did what you proposed. This has the added benefit that we are always in sync with the checks and behaviour provided by WebIDL.

<var>dec</var>'s <a for=TextDecoderStream>stream</a>. If this throws an exception, then return a
promise rejected with that exception
promise rejected with that exception.

<li><p>Let <var>controller</var> be <var>dec</var>'s
<a for=GenericTransformStream>transform</a>.\[[transformStreamController]].
Expand Down