Review Draft Publication: June 2019 #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is failing, I think because of validator warnings on the encoding tables. /cc @sideshowbarker to verify that warnings about Unicode normalization forms would cause a build failure. In that case we should probably implement #178. It appears the last successful build, 4 months ago, did not run the validator on the build output. https://travis-ci.org/whatwg/encoding/builds/491657427 |
It’s failing for the warnings because in https://github.com/whatwg/whatwg.org/blob/17fbe5071c59194dec4ce9442fc3ab1749052cb8/resources.whatwg.org/build/deploy.sh#L186-L190 we explicitly give the if [ -z "$CHECKER_FILTER" ]; then
./vnu-runtime-image/bin/vnu --skip-non-html --Werror "$WEB_ROOT"
else
./vnu-runtime-image/bin/vnu --skip-non-html --Werror --filterpattern "$CHECKER_FILTER" "$WEB_ROOT"
fiThat causes warnings to be treated as errors; so if there are any warnings, the process exits non-zero. But as I mentioned in #178 (comment), I think we can work around this by making the checker suppress/filter out those warnings. |
sideshowbarker
added a commit
that referenced
this pull request
Jun 19, 2019
This change sets the CHECKER_FILTER environment variable with a value that causes some particular warnings to be suppressed when the https://github.com/whatwg/whatwg.org/blob/master/resources.whatwg.org/build/deploy.sh script invokes the HTML checker on the Encoding build output. The particular warnings that get suppressed are: * Text run is not in Unicode Normalization Form C. * Document uses the Unicode Private Use Area(s), which should not be used in publicly exchanged documents. (Charmod C073) Otherwise, without this change, deployment of the Encoding spec will fail, because the https://github.com/whatwg/whatwg.org/blob/master/resources.whatwg.org/build/deploy.sh script causes the HTML checker to be invoked with the --Werror argument, which causes warnings to be treated as errors, which in turn causes the HTML checker process to exit non-zero. Fixes #178 Relates to #177
sideshowbarker
added a commit
that referenced
this pull request
Jun 19, 2019
This change sets the CHECKER_FILTER environment variable with a value that causes some particular warnings to be suppressed when the https://github.com/whatwg/whatwg.org/blob/master/resources.whatwg.org/build/deploy.sh script invokes the HTML checker on the Encoding build output. The particular warnings that get suppressed are: * Text run is not in Unicode Normalization Form C. * Document uses the Unicode Private Use Area(s), which should not be used in publicly exchanged documents. (Charmod C073) Otherwise, without this change, deployment of the Encoding spec will fail, because the https://github.com/whatwg/whatwg.org/blob/master/resources.whatwg.org/build/deploy.sh script causes the HTML checker to be invoked with the --Werror argument, which causes warnings to be treated as errors, which in turn causes the HTML checker process to exit non-zero. Fixes #178 Relates to #177
sideshowbarker
added a commit
that referenced
this pull request
Jun 19, 2019
This change sets the CHECKER_FILTER environment variable with a value that causes some particular warnings to be suppressed when the https://github.com/whatwg/whatwg.org/blob/master/resources.whatwg.org/build/deploy.sh script invokes the HTML checker on the Encoding build output. The particular warnings that get suppressed are: * Text run is not in Unicode Normalization Form C. * Document uses the Unicode Private Use Area(s), which should not be used in publicly exchanged documents. (Charmod C073) Otherwise, without this change, deployment of the Encoding spec will fail, because the https://github.com/whatwg/whatwg.org/blob/master/resources.whatwg.org/build/deploy.sh script causes the HTML checker to be invoked with the --Werror argument, which causes warnings to be treated as errors, which in turn causes the HTML checker process to exit non-zero. Fixes #178 Relates to #177
sideshowbarker
added a commit
that referenced
this pull request
Jun 19, 2019
This change sets the CHECKER_FILTER environment variable with a value that causes some particular warnings to be suppressed when the https://github.com/whatwg/whatwg.org/blob/master/resources.whatwg.org/build/deploy.sh script invokes the HTML checker on the Encoding build output. The particular warnings that get suppressed are: * Text run is not in Unicode Normalization Form C. * Document uses the Unicode Private Use Area(s), which should not be used in publicly exchanged documents. (Charmod C073) Otherwise, without this change, deployment of the Encoding spec will fail, because the https://github.com/whatwg/whatwg.org/blob/master/resources.whatwg.org/build/deploy.sh script causes the HTML checker to be invoked with the --Werror argument, which causes warnings to be treated as errors, which in turn causes the HTML checker process to exit non-zero. Fixes #178 Relates to #177
sideshowbarker
added a commit
that referenced
this pull request
Jun 19, 2019
This change adds an .htmlcheckerfilter file containing regular-expression patterns that causes some particular warnings to be suppressed when the https://github.com/whatwg/whatwg.org/blob/master/resources.whatwg.org/build/deploy.sh script invokes the HTML checker on the Encoding build output. The particular warnings that get suppressed are: * Text run is not in Unicode Normalization Form C. * Document uses the Unicode Private Use Area(s), which should not be used in publicly exchanged documents. (Charmod C073) Otherwise, without this change, deployment of the Encoding spec will fail, because the https://github.com/whatwg/whatwg.org/blob/master/resources.whatwg.org/build/deploy.sh script causes the HTML checker to be invoked with the --Werror argument, which causes warnings to be treated as errors, which in turn causes the HTML checker process to exit non-zero. Fixes #178 Relates to #177
sideshowbarker
added a commit
that referenced
this pull request
Jun 19, 2019
This change adds an .htmlcheckerfilter file containing regular-expression patterns that causes some particular warnings to be suppressed when the https://github.com/whatwg/whatwg.org/blob/master/resources.whatwg.org/build/deploy.sh script invokes the HTML checker on the Encoding build output. The particular warnings that get suppressed are: * Text run is not in Unicode Normalization Form C. * Document uses the Unicode Private Use Area(s), which should not be used in publicly exchanged documents. (Charmod C073) Otherwise, without this change, deployment of the Encoding spec will fail, because the https://github.com/whatwg/whatwg.org/blob/master/resources.whatwg.org/build/deploy.sh script causes the HTML checker to be invoked with the --Werror argument, which causes warnings to be treated as errors, which in turn causes the HTML checker process to exit non-zero. Fixes #178 Relates to #177
annevk
pushed a commit
that referenced
this pull request
Jun 19, 2019
This change adds an .htmlcheckerfilter file containing regular-expression patterns that causes some particular warnings to be suppressed when the https://github.com/whatwg/whatwg.org/blob/master/resources.whatwg.org/build/deploy.sh script invokes the HTML checker on the Encoding build output. The particular warnings that get suppressed are: * Text run is not in Unicode Normalization Form C. * Document uses the Unicode Private Use Area(s), which should not be used in publicly exchanged documents. (Charmod C073) Otherwise, without this change, deployment of the Encoding spec will fail, because the https://github.com/whatwg/whatwg.org/blob/master/resources.whatwg.org/build/deploy.sh script causes the HTML checker to be invoked with the --Werror argument, which causes warnings to be treated as errors, which in turn causes the HTML checker process to exit non-zero. Fixes #178. Relates to #177.
annevk
force-pushed
the
review-draft-2019-06-17
branch
from
789457c
to
0882eed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Review Draft for this Workstream will be published shortly, by merging this pull request.
Under the WHATWG IPR Policy, Participants may, within 45 days after publication of a Review Draft, exclude certain Essential Patent Claims from the Review Draft Licensing Obligations. See the IPR Policy for details.