Use new Streams algorithm and mixins #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
added
the
do not merge yet
annevk
approved these changes
Aug 28, 2020
|
|
||
| <li><p>Set <a>this</a>'s <a for=GenericTransformStream>transform</a> to <var>transform</var>. | ||
| <li><p>Set <a>this</a>'s <a for=GenericTransformStream>transform</a> to the result of | ||
| <a for=TransformStream>creating</a> a {{TransformStream}} with |
There was a problem hiding this comment.
Suggested change
| <a for=TransformStream>creating</a> a {{TransformStream}} with | |
| <a for=TransformStream>creating</a> a {{TransformStream}} object with |
There was a problem hiding this comment.
This mismatches the algorithm declaration, which does not include "object".
Co-authored-by: Andreu Botella <abb@randomunok.com>
annevk
force-pushed
the
streams-integration
branch
from
5ec8d08
to
d97b9f2
Compare
|
I rebased this and pushed some nits and corrected things that seemed wrong. Still needs upstream changes to merge. |
|
Thank you for catching those; your changes LGTM. Will work on getting upstream working now. |
|
The Streams PR is merged; once the link databases update let's re-run CI and see if this works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows whatwg/streams#1073.
Preview | Diff