Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal to block 4190 (sieve) and 6679 (osaut, irc+tls alternate) #1663

Closed
annevk opened this issue May 26, 2023 · 7 comments · Fixed by #1743
Closed

Proposal to block 4190 (sieve) and 6679 (osaut, irc+tls alternate) #1663

annevk opened this issue May 26, 2023 · 7 comments · Fixed by #1743
Labels
addition/proposal New features or enhancements needs implementer interest Moving the issue forward requires implementers to express interest topic: port blocking

Comments

@annevk
Copy link
Member

annevk commented May 26, 2023

I noticed WebKit has been blocking these for the past six years or so. I'm happy to work on PRs if there's agreement to standardize.

cc @ricea @mozfreddyb
@annevk annevk added addition/proposal New features or enhancements needs implementer interest Moving the issue forward requires implementers to express interest topic: port blocking labels May 26, 2023
@mozfreddyb
Copy link
Collaborator

CC @valenting

@ricea
Copy link
Collaborator

ricea commented May 29, 2023

Blocking new ports creates a lot of work for enterprise users. I'd rather not do it without clear evidence of a risk.

@annevk
Copy link
Member Author

annevk commented May 29, 2023

As I understand it both ports have been used and probably are still used for text protocols that can be spoofed.

@ricea
Copy link
Collaborator

ricea commented Jun 2, 2023

Sorry for being slow, I haven't found evidence of extensive use of these ports that would worry me, but I want to do a bit more research.

@annevk
Copy link
Member Author

annevk commented Mar 25, 2024

@ricea has that research been completed? @valenting any thoughts from Gecko?

@valenting
Copy link

I don't have any concerns regarding this change. I'm happy to standardize on a common list of blocked ports.
Here are the ports currently blocked in Gecko

annevk added a commit to web-platform-tests/wpt that referenced this issue Mar 26, 2024
@annevk
Fetch: block ports 4190 & 6679
f9b5855 
For whatwg/fetch#1663.
@annevk annevk mentioned this issue Mar 26, 2024
Merged
annevk added a commit that referenced this issue Mar 26, 2024
@annevk
Block ports 4190 & 6679
3238092 
Tests: web-platform-tests/wpt#45350.

Fixes #1663.
@annevk annevk mentioned this issue Mar 26, 2024
Merged
5 tasks
@annevk
Copy link
Member Author

annevk commented Mar 26, 2024

PR and tests are now up. I'll merge it all a week from now barring any unforeseen comments.

annevk added a commit to web-platform-tests/wpt that referenced this issue Apr 2, 2024
@annevk
Fetch: block ports 4190 & 6679
b751f4b 
For whatwg/fetch#1663.
annevk added a commit to web-platform-tests/wpt that referenced this issue Apr 2, 2024
@annevk
Fetch: block ports 4190 & 6679
6c6f8a9 
For whatwg/fetch#1663.
annevk added a commit that referenced this issue Apr 2, 2024
@annevk
Block ports 4190 & 6679
4c3750d 
Tests: web-platform-tests/wpt#45350.

Fixes #1663.
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Apr 10, 2024
@annevk @moz-wptsync-bot
Bug 1888061 [wpt PR 45350] - Fetch: block ports 4190 & 6679, a=testonly
42d0195 
Automatic update from web-platform-tests
Fetch: block ports 4190 & 6679

For whatwg/fetch#1663.
--

wpt-commits: 6c6f8a91e970250b526794289906ab53e04f6f32
wpt-pr: 45350
ErichDonGubler pushed a commit to ErichDonGubler/firefox that referenced this issue Apr 15, 2024
@annevk @moz-wptsync-bot
Bug 1888061 [wpt PR 45350] - Fetch: block ports 4190 & 6679, a=testonly
2ed8fce 
Automatic update from web-platform-tests
Fetch: block ports 4190 & 6679

For whatwg/fetch#1663.
--

wpt-commits: 6c6f8a91e970250b526794289906ab53e04f6f32
wpt-pr: 45350
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
addition/proposal New features or enhancements needs implementer interest Moving the issue forward requires implementers to express interest topic: port blocking
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Block ports 4190 & 6679 whatwg/fetch
4 participants
@valenting @annevk @mozfreddyb @ricea