Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename simple header #277

Closed
annevk opened this issue Apr 10, 2016 · 4 comments
Closed

Rename simple header #277

annevk opened this issue Apr 10, 2016 · 4 comments
Labels
good first issue Ideal for someone new to a WHATWG standard or software project

Comments

@annevk
Copy link
Member

annevk commented Apr 10, 2016

"CORS-safelisted request-header" seems much more appropriate. Realized this while merging #258.
@annevk annevk added the good first issue Ideal for someone new to a WHATWG standard or software project label Apr 10, 2016
@vigneshshanmugam
Copy link
Member

I can take this up. Does it need to be changed across all instances of "simple header"?

@annevk
Copy link
Member Author

annevk commented Apr 16, 2016

Thank you! Yeah, everything that cross-references the <dfn> version using <span>. As part of the same change we should probably also move "CORS-safelisted response-header name" up to be just under it (before "forbidden header name").

(Also, nice to run into you online 😊.)

@vigneshshanmugam
Copy link
Member

vigneshshanmugam commented Apr 16, 2016 •
edited

Thanks @annevk. Will update and send a PR.

(Happy that you remember me :D )

@vigneshshanmugam vigneshshanmugam mentioned this issue Apr 16, 2016
Closed
@annevk annevk closed this as completed in 963ec56 Apr 18, 2016
@tyoshino
Copy link
Member

Nice renaming! Thanks

annevk added a commit that referenced this issue May 26, 2016
@annevk
Rename simple method to CORS-safelisted method
97fc638 
Forgot about methods when I filed #277. Much more important to be clear
here than brief.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Ideal for someone new to a WHATWG standard or software project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@annevk @vigneshshanmugam @tyoshino