Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use forgiving-base64 encode for WebSocket #712

Closed
annevk opened this issue Apr 18, 2018 · 0 comments
Closed

Use forgiving-base64 encode for WebSocket #712

annevk opened this issue Apr 18, 2018 · 0 comments
Labels
clarification Standard could be clearer good first issue Ideal for someone new to a WHATWG standard or software project topic: websockets

Comments

@annevk
Copy link
Member

annevk commented Apr 18, 2018

It's identical to what we reference now, but we'd have one base64 story throughout the document, which seems a little better.
@annevk annevk added good first issue Ideal for someone new to a WHATWG standard or software project topic: websockets clarification Standard could be clearer labels Apr 18, 2018
@annevk annevk changed the title Use forgiving base64-encode for WebSocket Use forgiving-base64 encode for WebSocket Apr 18, 2018
@Garee Garee mentioned this issue Dec 1, 2018
Merged
annevk pushed a commit that referenced this issue Dec 13, 2018
@Garee @annevk
Use forgiving-base64 encode on WebSocket's keyValue
e263769 
This improves the consistency of the document by referencing the same type of base64-encoding throughout. Also isomorphic encode it as base64 encoding returns a string.

Fixes #712.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
clarification Standard could be clearer good first issue Ideal for someone new to a WHATWG standard or software project topic: websockets
Milestone
No milestone
Development

No branches or pull requests
1 participant
@annevk