Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add style rules #1036

Merged
merged 5 commits into from Jun 15, 2020
Merged

Add style rules #1036

merged 5 commits into from Jun 15, 2020

Conversation

yutakahirano
Copy link
Member

Add style rules for new lines and names.

Add style rules for new lines and names.
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for writing this up, this is great! I have a couple nits and suggestions.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@annevk annevk merged commit b228c33 into master Jun 15, 2020
@annevk annevk deleted the yhirano/readme-style branch June 15, 2020 11:21
annevk added a commit to whatwg/spec-factory that referenced this pull request Sep 27, 2023
This was originally contributed in whatwg/fetch#1036 by yutakahirano and should be preserved (and spread!).
annevk added a commit to whatwg/spec-factory that referenced this pull request Sep 27, 2023
…-part

These formatting rules were originally contributed in whatwg/fetch#1036 by yutakahirano and should be preserved (and spread!).

Additionally, ensure we don't keep reading the same .template-part file over and over as that gives funny results.

And finally make it so that --single doesn't checkout the main branch and pulls, as that is almost never what you want when selectively deploying changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants