Adapt to changes in Streams #1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
added
the
do not merge yet
domenic
added a commit
to whatwg/streams
that referenced
this pull request
Jun 26, 2020
Although the long-term relationship isn't obvious, whatwg/fetch#1044 wants this at least for now
Fixes #780. Fixes #976. Follows whatwg/streams#1045.
domenic
force-pushed
the
update-streams-usage
branch
from
3f565fa
to
056878d
Compare
ricea
reviewed
Jun 26, 2020
fetch.bs
Outdated
Comment on lines
1718
to
1719
| <li><p>If the ongoing fetch is not <a for=fetch>terminated</a>, then perform the | ||
| <a>transmit-body loop</a> given <var>request</var>, <var>body</var>, and <var>reader</var>. |
There was a problem hiding this comment.
This seems like cheating. Don't we have to post a task to get back out of "in parallel"?
There was a problem hiding this comment.
Yes, oops, I meant to do that.
domenic
removed
the
do not merge yet
|
The corresponding streams PR has been merged, although we need to wait 24 hours or so before the linking database updates and we can remove the whatpr.org links. |
domenic
added
the
do not merge yet
domenic
removed
the
do not merge yet
|
This is ready to merge, @annevk. |
annevk
approved these changes
Jul 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #780. Fixes #976. Follows whatwg/streams#1045.
(At least, I think this fixes #976. That's a long issue with lots of text, but this significantly reduces the amount of "in parallel" that happens in upload streaming, so it seems likely to address the problem.)
This should land after whatwg/streams#1045 and needs some updates once it does, so tagging "do not merge yet". But it's ready for review.
The "looping" algorithms could potentially use better names; bikeshed help welcome.
Preview | Diff