Add abstractions for creating Request and Response objects #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annevk
commented
Feb 1, 2021
|
|
||
| <li><p><a>Abort fetch</a> with <var>p</var>, <var>request</var>, and | ||
| <var>responseObject</var>. | ||
| <li><p><a>Abort fetch</a> with <var>p</var>, <var>request</var>, and <var>responseObject</var>. |
There was a problem hiding this comment.
I'm not sure if this works as at this point responseObject is null and later it might get a value at which point we'd want this to operate on that value I think. Is there a better way to tackle this?
There was a problem hiding this comment.
Could you check the signal right before creating the response object?
jakearchibald
requested changes
Feb 1, 2021
|
For the eventual commit message:
|
| @@ -6633,7 +6653,8 @@ method steps are: | |||
| <li><p>If <var>response</var> is a <a>network error</a>, then <a for=/>reject</a> <var>p</var> | |||
| with a {{TypeError}} and terminate these substeps. | |||
|
|
|||
| <li><p>Associate <var>responseObject</var> with <var>response</var>. | |||
| <li><p>Set <var>responseObject</var> to the result of <a for=Response>creating</a> a {{Response}} | |||
There was a problem hiding this comment.
If you're worried about races between this and the "Abort fetch" line above, you could check the state locallyAborted and abort these steps if it's true.
There was a problem hiding this comment.
That's step 1 here so I think we're good, no?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #771.
Preview | Diff