Clarify cors requests need cors response tainting #1170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change clarifies a (non-normative) statement that "cors" request mode is what makes a request into a cors request. In fact, for requests with "cors" request mode, "cors" response tainting is also necessary in order for the request to be considered a cors request. So this change refines the relevant statement to make that clear. Otherwise, without this change, considering the case of a same-origin GET request whose mode is "cors", the spec is claiming that same-origin GET request is a cors request. But because the spec defines a "cors request" as “an HTTP request that includes an `Origin` header”, a same-origin GET request cannot in fact be a cors request — because it doesn’t include an `Origin` header. (And that’s because for GET requests, the spec requires an `Origin` header to be appended only if the request’s response tainting is "cors"; but for same-origin requests, the request’s response tainting will be "basic".)
annevk
reviewed
Feb 17, 2021
fetch.bs
Outdated
| @@ -1390,7 +1390,8 @@ to not have to set <a for=/>request</a>'s <a for=request>referrer</a>. | |||
| <a>network error</a> if the request is not made to a same-origin URL. | |||
|
|
|||
| <dt>"<code>cors</code>" | |||
| <dd>Makes the request a <a>CORS request</a>. Fetch will return a <a>network error</a> if the | |||
| <dd>For requests whose <a for=request>response tainting</a> is also "<code>cors</code>", makes the | |||
There was a problem hiding this comment.
"gets set to" seems more accurate since response tainting is not set by those creating the request.
There was a problem hiding this comment.
"gets set to" seems more accurate since response tainting is not set by those creating the request.
Made it so
annevk
reviewed
Feb 17, 2021
fetch.bs
Outdated
| @@ -1390,7 +1390,8 @@ to not have to set <a for=/>request</a>'s <a for=request>referrer</a>. | |||
| <a>network error</a> if the request is not made to a same-origin URL. | |||
|
|
|||
| <dt>"<code>cors</code>" | |||
| <dd>Makes the request a <a>CORS request</a>. Fetch will return a <a>network error</a> if the | |||
| <dd>For requests whose <a for=request>response tainting</a> gets set to "<code>cors</code>", makes | |||
| the request a <a>CORS request</a> — in which case, fetch will return a <a>network error</a> if the | |||
| requested resource does not understand the <a>CORS protocol</a>. | |||
There was a problem hiding this comment.
Sorry, noticed this afterwards, but maybe you want to improve this as well since the resource might well understand it, but not wish to share.
There was a problem hiding this comment.
Went with: “or if the requested resource is one that intentionally does not participate in the CORS protocol”
annevk
deleted the
sideshowbarker/cors-request-requires-response-tainting-equals-cors
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change clarifies a (non-normative) statement that "cors" request mode is what makes a request into a cors request. In fact, for requests with "cors" request mode, "cors" response tainting is also necessary in order for the request to be considered a cors request. So this change refines the relevant statement to make that clear.
Otherwise, without this change, considering the case of a same-origin GET request whose mode is "cors", the spec is claiming that same-origin GET request is a cors request.
But because the spec defines a "cors request" as “an HTTP request that includes an
Originheader”, a same-origin GET request cannot in fact be a cors request — because it doesn’t include anOriginheader. (And that’s because for GET requests, the spec requires anOriginheader to be appended only if the request’s response tainting is "cors"; but for same-origin requests, the request’s response tainting will be "basic".)Preview | Diff