Clarify: credentials param affect response too #1174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates the descriptions of all “credentials mode” values, to clarify that the values affect whether browsers use credentials sent back in responses (e.g., any Set-Cookie response headers) — not just whether credentials are sent with the request.
sideshowbarker
force-pushed
the
sideshowbarker/credentials-param-clarify
branch
from
909fb31
to
9a964ec
Compare
sideshowbarker
added a commit
to mdn/content
that referenced
this pull request
Feb 19, 2021
This change updates the documentation on the fetch() method, to clarify that the "credentials" value affects whether browsers use credentials sent back in responses (e.g., any Set-Cookie response headers) — not just whether credentials are sent with the request Fixes #2409 Related: whatwg/fetch#1174
annevk
approved these changes
Feb 19, 2021
For developers reading it, it seems best to be as explicit as possible — so if the Set-Cookie header is the only form or credentials the response can have which would be affected, then let’s say that. |
|
Sorry, I'm wrong. It also affects 401 responses (and connection pooling). (Search for includeCredentials.) |
sideshowbarker
force-pushed
the
sideshowbarker/credentials-param-clarify
branch
from
9b7366c
to
9a964ec
Compare
OK — stripped out the other commit |
annevk
reviewed
Feb 19, 2021
annevk
approved these changes
Feb 19, 2021
|
Thanks @sideshowbarker! |
Rumyra
pushed a commit
to mdn/content
that referenced
this pull request
Feb 19, 2021
…oo (#2468) * Push the “fix fixable flaws” button * Fetch response cookies affected by credentials This change updates the documentation on the fetch() method, to clarify that the "credentials" value affects whether browsers use credentials sent back in responses (e.g., any Set-Cookie response headers) — not just whether credentials are sent with the request Fixes #2409 Related: whatwg/fetch#1174 * Fold URL object under USVString as resource value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the descriptions of all “credentials mode” values, to clarify that the values affect whether browsers use credentials sent back in responses (e.g., any Set-Cookie response headers) — not just whether credentials are sent with the request. Related: mdn/content#2468
Preview | Diff