Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add abort reason to abort fetch #1343
Add abort reason to abort fetch #1343
Changes from 2 commits
a18ee76
6e0fe40
4a06427
eb499b4
c0833a5
55d734e
4df5ef6
75d4bad
b6ddcaa
ba73b86
ddd1628
62edcfe
14dac0d
8194bf6
f660a6e
2255611
f44930c
122bae5
cc54cd6
647f4f5
e5b0236
1b86ddc
b6a779d
6a0f4aa
63ad081
f86437e
38ea956
662fe10
70ade67
a29fd77
01a87c0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
error is always given I think, but it can be undefined. I think the text here and in Streams suggest we should have this primitive in DOM.
Something like
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An alternative might be to pass the signal on and then we define
That might make it a bit easier to use. I.e., callers can say "throw signal's error".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But can it ever be undefined? It seems both
AbortController#abort
and staticAbortSignal.abort
sets the reason if undefined.