Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: Fix incorrect variable name in 'create a Request object' #1494

Merged
merged 1 commit into from Sep 26, 2022
Merged

Editorial: Fix incorrect variable name in 'create a Request object' #1494

merged 1 commit into from Sep 26, 2022

Conversation

linusg
Copy link
Member

@linusg linusg commented Sep 24, 2022 •
edited by pr-preview bot

@linusg
Editorial: Fix incorrect variable name in 'create a Request object'
5a3dd55 
The `request` variable is the underlying request that was passed to the
operation, not the newly created Request JS object, which is stored as
`requestObject`.
annevk
annevk approved these changes Sep 26, 2022
View reviewed changes
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for spotting and fixing a two year old (!) typo!

@annevk annevk merged commit b3ac07c into whatwg:main Sep 26, 2022
@linusg linusg deleted the request-create-fix branch September 26, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@linusg @annevk