Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a destination type for FedCM #1495

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Add a destination type for FedCM #1495

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion fetch.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1517,6 +1517,7 @@ the empty string,
"<code>style</code>",
"<code>track</code>",
"<code>video</code>",
"<code>webidentity</code>",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this have been added to the dictionary too, or how is https://fetch.spec.whatwg.org/#dom-request-destination supposed to work?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It depends a bit on whether it's exposed to service workers, but if it is then yes. I filed #1500 on that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing that out. It is not exposed to service workers but I'll let Anne handle the question of whether it should be added to the enum anyway, since they have a patch already.

"<code>worker</code>", or
"<code>xslt</code>". Unless stated otherwise it is the empty string.

Expand Down Expand Up @@ -1548,7 +1549,7 @@ not always relevant and might require different behavior.
<th>CSP directive
<th>Features
<tr>
<td rowspan=19>""
<td rowspan=20>""
<td>"<code>report</code>"
<td rowspan=2>&mdash;
<td>CSP, NEL reports.
Expand Down Expand Up @@ -1611,6 +1612,10 @@ not always relevant and might require different behavior.
<td>"<code>sharedworker</code>"
<td><code>child-src</code>, <code>script-src</code>, <code>worker-src</code>
<td><code>SharedWorker</code>
<tr>
<td>"<code>webidentity</code>"
<td><code>connect-src</code>
<td><code>Federated Credential Management requests</code>
<tr>
<td>"<code>worker</code>"
<td><code>child-src</code>, <code>script-src</code>, <code>worker-src</code>
Expand Down