Editorial: add <div algorithm> wrappers to Header class #1596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annevk
reviewed
Jan 25, 2023
fetch.bs
Outdated
| <p>The <dfn export for=Headers method><code>delete(<var>name</var>)</code></dfn> method steps are: | ||
| <div algorithm> | ||
| <p>The <dfn export for=Headers method><code>delete(<var>name</var>)</code></dfn> method | ||
| from a {{Headers}} object (<var>headers</var>), run these steps: |
There was a problem hiding this comment.
You found a bug, nice! The fix is replacing headers below with <a>this</a>. This can stay as-is. I suppose the same applies to set() below.
There was a problem hiding this comment.
Ah! Good point. Originally I thought this would be like remove privileged no-CORS request-headers, but it makes sense that we'd use this for these methods.
dlrobertson
commented
Jan 25, 2023
fetch.bs
Outdated
| <p>The <dfn export for=Headers method><code>delete(<var>name</var>)</code></dfn> method steps are: | ||
| <div algorithm> | ||
| <p>The <dfn export for=Headers method><code>delete(<var>name</var>)</code></dfn> method | ||
| from a {{Headers}} object (<var>headers</var>), run these steps: |
There was a problem hiding this comment.
Ah! Good point. Originally I thought this would be like remove privileged no-CORS request-headers, but it makes sense that we'd use this for these methods.
|
Updated to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #1526
Preview | Diff