Editorial: Reword how-to section to explain how to use callbacks & controller #1614
Conversation
There was a problem hiding this comment.
This looks great, thanks! I think we should also run it by a couple of the more novice specification authors who have wondered how to integrate with Fetch recently, to see if it answers their questions. I'll send it to a couple once you've had a chance to integrate or disagree with my comments here.
Thanks! I accepted all your suggestions. |
There was a problem hiding this comment.
Thanks for your work on this!
There's two outstanding comments from @jyasskin as well that need to be addressed, though note that one is slightly incorrect with respect to URLs being strings.
Generally I would not talk about "downloading" here as that's its own term of art within the context of navigation. Fetch fetches or obtains.
To set expectations, this needs at least one more close look after these issues are addressed.
Apologies, some of them I genuinely didn't know were mistakes, but a few I totally missed. Always trying to improve at this... |
|
There are still many unresolved conversations above. Could you either resolve them or note what's needed to resolve them? |
Done (I was looking at the file view so I missed those). |
Instead of describing the callbacks one by one, put emphasis on how/when the caller expects responses (upon completion, chunk-by-chunk, fire-and-forget). This (hopefully) gives other specs who need to call into Fetch a quick reference between what they're trying to do and the API. Co-Authored-By: Domenic Denicola <d@domenic.me> Co-Authored-By: Anne van Kesteren <annevk@annevk.nl> Co-Authored-By: Jeffrey Yasskin <jyasskin@gmail.com>
Instead of describing the callbacks one by one, putting emphasis on how/when the caller expects responses (upon completion, chunk-by-chunk, fire-and-forget).
This (hopefully) gives other specs who need to call into Fetch a quick reference between what they're trying to do and the API.
(See WHATWG Working Mode: Changes for more details.)
Preview | Diff