Pass recursive=false to manual navigation redirect #1638
Conversation
| <p>If <var>request</var>'s <a for=request>redirect mode</a> is "<code>manual</code>", then: | ||
|
|
||
| <ol> | ||
| <li><p>Assert: <var>request</var>'a <a for=request>mode</a> is "<code>navigate</code>". |
There was a problem hiding this comment.
This is incorrect. You can always set it to "manual" and get an opaque response at the moment. Mainly useful in service workers with navigations though.
I suggest we do something like
Let recursive be true if ....; otherwise false.
instead.
There was a problem hiding this comment.
Yea but if it's manual non-navigation you wouldn't get to this bit as fetch would never process your redirect. Anyway, revised.
There was a problem hiding this comment.
Wait, that's good pushback and solid rationale. Why revise?
There was a problem hiding this comment.
Mainly because that assert is potentially more confusing than helpful and I wasn't sure about it. Should we keep it or throw it? I could go either way.
There was a problem hiding this comment.
Given that it's correct it seems like a good addition.
This reverts commit f56575b.
annevk
changed the title
Closes #1629
Preview | Diff