Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully read's processBodyError argument needs to take an exception #1650

Merged
merged 1 commit into from
May 13, 2023

Conversation

annevk
Copy link
Member

@annevk annevk commented May 4, 2023

Fixes #1636.


Preview | Diff

Copy link

@AtkinsSJ AtkinsSJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! We still have some gaps in our Fetch implementation, but as far as I can tell this solves the issue.

AtkinsSJ added a commit to AtkinsSJ/serenity that referenced this pull request May 13, 2023
@annevk annevk merged commit 018ac19 into main May 13, 2023
1 check passed
@annevk annevk deleted the annevk/full-read-error branch May 13, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

"consume body" step disagrees with "fully read" on whether the error callback accepts an argument
2 participants