Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: define return types of most header list algorithms #1660

Merged
merged 2 commits into from
May 22, 2023

Conversation

annevk
Copy link
Member

@annevk annevk commented May 22, 2023

Fixes #1659.


Preview | Diff

@annevk annevk requested a review from domenic May 22, 2023 06:43
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I think "return nothing" can be assumed in some cases.

fetch.bs Outdated
@@ -615,7 +616,8 @@ given a <a for=/>header name</a> <var>name</var> and a string <var>type</var> fr
<p>To
<dfn export for="header list" id=concept-header-list-set-structured-header>set a structured field value</dfn>
given a <a for=/>tuple</a> (<a for=/>header name</a> <var>name</var>, <a>structured field value</a>
<var>structuredValue</var>), in a <a for=/>header list</a> <var>list</var>, run these steps:
<var>structuredValue</var>), in a <a for=/>header list</a> <var>list</var>, run these steps. They
return nothing.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessary for the setter-type algorithms IMO.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough.

@annevk annevk merged commit 6f032a2 into main May 22, 2023
2 checks passed
@annevk annevk deleted the annevk/header-list-return-types branch May 22, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Header list "get" return type is unclear
2 participants