Editorial: Export fetch controller/serialized abort reason #1736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is referenced [1] by the Service Worker spec, so should either be exported or something else to achieve the same thing would need to exist (forwarding the "abort reason" from a fetch controller to an AbortController; note that the service worker algorithm is currently extra confusing because it uses the same variable name for two different objects). [1]: https://w3c.github.io/ServiceWorker/#clients-openwindow:~:text=If%20controller%E2%80%99s%20serialized%20abort%20reason%20is%20non%2Dnull
|
Exporting that looks reasonable. (Aside: it looks like "deserialize a serialized abort reason" could be used there too for consistency w/ fetch? It's already used a bit earlier in handle fetch.)
Ugh I think I added that second one :(. Happy to fix that if you're already doing so. |
noamr
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is referenced 1 by the Service Worker spec, so should either be exported or something else to achieve the same thing would need to exist (forwarding the "abort reason" from a fetch controller to an AbortController; note that the service worker algorithm is currently extra confusing because it uses the same variable name for both "controller" objects).
Preview | Diff