Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update request's referrer policy when fetching #280

Merged
merged 3 commits into from Apr 14, 2016
Merged

Update request's referrer policy when fetching #280

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d7dd61e
wip
yutakahirano Apr 12, 2016
c5c0ac3
fix
yutakahirano Apr 13, 2016
b2006e3
fix
yutakahirano Apr 13, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 12 additions & 1 deletion Overview.html
View file
Open in desktop
Expand Up @@ -7,7 +7,7 @@

<p><a class="logo" href="https://whatwg.org/"><img alt="WHATWG" height="100" src="https://resources.whatwg.org/logo-fetch.svg" width="100"></a>
<h1 id="cors">Fetch</h1>
<h2 class="no-num no-toc" id="living-standard-—-last-updated-10-april-2016">Living Standard — Last Updated 10 April 2016</h2>
<h2 class="no-num no-toc" id="living-standard-—-last-updated-12-april-2016">Living Standard — Last Updated 12 April 2016</h2>

<dl>
<dt>Participate:
Expand Down Expand Up @@ -2101,6 +2101,17 @@ <h3 id="main-fetch"><span class="secno">5.1 </span>Main fetch</h3>
<a href="#refsMIX">[MIX]</a>
<a href="#refsCSP">[CSP]</a>

<li><p>If <var>request</var>'s <a href="#concept-request-referrer-policy" title="concept-request-referrer-policy">referrer policy</a>
is the empty string and <var>request</var>'s
<a href="#concept-request-client" title="concept-request-client">client</a> is non-null, set <var>request</var>'s
<a href="#concept-request-referrer-policy" title="concept-request-referrer-policy">referrer policy</a> to <var>request</var>'s
<a href="#concept-request-client" title="concept-request-client">client</a>'s associated referrer policy.

<li><p>If <var>request</var>'s <a href="#concept-request-referrer-policy" title="concept-request-referrer-policy">referrer policy</a>
is the empty string, set <var>request</var>'s
<a href="#concept-request-referrer-policy" title="concept-request-referrer-policy">referrer policy</a> to
"<code>no-referrer-when-downgrade</code>".

<li>
<p>If <var>request</var>'s <a href="#concept-request-referrer" title="concept-request-referrer">referrer</a>
is not "<code>no-referrer</code>", set <var>request</var>'s
Expand Down
11 changes: 11 additions & 0 deletions Overview.src.html
View file
Open in desktop
Expand Up @@ -2031,6 +2031,17 @@ <h3>Main fetch</h3>
<span data-anolis-ref>MIX</span>
<span data-anolis-ref>CSP</span>

<li><p>If <var>request</var>'s <span title=concept-request-referrer-policy>referrer policy</span>
is the empty string and <var>request</var>'s
<span title=concept-request-client>client</span> is non-null, set <var>request</var>'s
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"then set"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

<span title=concept-request-referrer-policy>referrer policy</span> to <var>request</var>'s
<span title=concept-request-client>client</span>'s associated referrer policy.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is "associated referrer policy" defined? Would be nice to directly reference it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expected it would be added to https://www.w3.org/TR/html5/webappapis.html#settings-object by webappsec-referrer-policy authors in the future. Should I link to https://w3c.github.io/webappsec-referrer-policy/#referrer-policy?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think that would be good enough for now. Bit weird that they link to W3C HTML, which is hopelessly wrong.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a link.


<li><p>If <var>request</var>'s <span title=concept-request-referrer-policy>referrer policy</span>
is the empty string, set <var>request</var>'s
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"then set"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

<span title=concept-request-referrer-policy>referrer policy</span> to
"<code>no-referrer-when-downgrade</code>".
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should maybe add a note here that this is the historical default.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.


<li>
<p>If <var>request</var>'s <span title=concept-request-referrer>referrer</span>
is not "<code>no-referrer</code>", set <var>request</var>'s
Expand Down