Change combine and combined value to use 0x2C 0x20 #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 10, 2017
annevk
added a commit
to whatwg/xhr
that referenced
this pull request
Mar 10, 2017
In particular, setRequestHeader() should use 0x2C 0x20 as separator (not just 0x2C) and get(All)ResponseHeader(s)() should do so too. The latter also always needs to end in 0x0D 0x0A rather than omitting it at the end. This depends on whatwg/fetch#504 landing first. Tests: web-platform-tests/wpt#4641 and web-platform-tests/wpt#5008. Fixes #108 and fixes #109.
Instead of just 0x2C, use 0x2C 0x20 somewhat consistently (except where we can't and point it out) as that is what XMLHttpRequest implementations have always done and nobody likes too much change. Fixes the Fetch part of whatwg/xhr#108 and whatwg/xhr#109.
annevk
changed the title
annevk
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 10, 2017
|
Tests: web-platform-tests/wpt#5115. (There have also been tests modified on the XMLHttpRequest side. Those already landed.) |
annevk
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 10, 2017
|
Bugs filed are referenced in whatwg/xhr#108. |
annevk
added a commit
to whatwg/xhr
that referenced
this pull request
Mar 13, 2017
In particular, setRequestHeader() should use 0x2C 0x20 as separator (not just 0x2C) and get(All)ResponseHeader(s)() should do so too. The latter also always needs to end in 0x0D 0x0A rather than omitting it at the end. This depends on whatwg/fetch#504 landing first. Tests: web-platform-tests/wpt#4641, web-platform-tests/wpt#5008, and web-platform-tests/wpt#5115. Fixes #108 and fixes #109.
TimothyGu
pushed a commit
to node-fetch/node-fetch
that referenced
this pull request
Apr 2, 2017
The behavior was changed in whatwg/fetch#504.
MXEBot
pushed a commit
to mirror/chromium
that referenced
this pull request
Apr 20, 2017
Adapt to whatwg/fetch#504 and whatwg/xhr#130, which started requiring combined header list values to be separated by ", " instead of just ",". The XHR code handling responses already did that, but |ResourceRequest| and |FetchHeaderList| both had to be updated. As a bonus, this also makes us pass w-p-t's headers-combine.html. BUG=700434,705490 R=mkwst@chromium.org,tyoshino@chromium.org,yhirano@chromium.org Review-Url: https://codereview.chromium.org/2822183002 Cr-Commit-Position: refs/heads/master@{#465537}
fatboy0112
added a commit
to fatboy0112/node-fetch
that referenced
this pull request
Sep 22, 2023
The behavior was changed in whatwg/fetch#504.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of just 0x2C, use 0x2C 0x20 somewhat consistently (except where we can't and point it out) as that is what XMLHttpRequest implementations have always done and nobody likes too much change.
Fixes the Fetch part of whatwg/xhr#108 and whatwg/xhr#109.
Preview | Diff