Editorial: rename "basic fetch" to "scheme fetch" #537
Conversation
|
I like "scheme fetch". We should probably not change the IDs though or at the very least preserve the old IDs. The |
jugglinmike
force-pushed
the
generic-fetch
branch
2 times, most recently
from
25b687b
to
d9b8f6a
Compare
|
Sure thing. This required amending the commit message, so I've made the original version of this branch (including a fixup commit with the requested changes) available here: master...bocoup:generic-fetch-orig |
fetch.bs
Outdated
| <!-- Prior to May 2017, this algorithm was named "basic fetch." The | ||
| corresponding ID is maintained in order to preserve the functionality of | ||
| external references. --> | ||
| <h3 id=scheme-fetch><span id=basic-fetch>Scheme fetch</span></h3> |
There was a problem hiding this comment.
<h3 id=scheme-fetch oldids=basic-fetch>.
fetch.bs
Outdated
| <h3 id=basic-fetch>Basic fetch</h3> | ||
|
|
||
| <p>To perform a <dfn id=concept-basic-fetch for=basic>basic fetch</dfn> using | ||
| <p>To perform a <dfn id=concept-scheme-fetch>scheme fetch</dfn> using |
There was a problem hiding this comment.
Add oldids=concept-basic-fetch here too. I suspect both of these to have external links.
As it relates to the fetching algorithm, the term "basic" is sub-optimal for a number of reasons: - It implies a relative level of simplicity. Because the algorithm includes an invocation of HTTP Fetch, it is conceptually more complex than most other fetching algorithms defined in the specification. - It suggests a relationship to the "basic" request tainting value and "basic" filtered response. While the algorithm is invoked for requests whose tainting is "basic", it is also invoked for requests whose tainting is set to "opaque". Re-name the algorithm to "scheme fetch" in order to more precisely describe its behavior while avoiding association with any particular request tainting value.
|
Wow, Bikeshed is a great tool! I've shorted the accompanying comment as it is now clear that this practice is pretty common. Force-pushed to facilitate merging, but the individual commits are available on the branch I reference above. |
jugglinmike
changed the title
|
Thanks! |
|
Sure thing :) |
As it relates to the fetching algorithm, the term "basic" is sub-optimal
for a number of reasons:
includes an invocation of HTTP Fetch, it is conceptually more complex
than most other fetching algorithms defined in the specification.
"basic" filtered response. While the algorithm is invoked for requests
whose tainting is "basic", it is also invoked for requests whose
tainting is set to "opaque".
Re-name the algorithm to "scheme fetch" in order to more precisely
describe its behavior while avoiding association with any particular
request tainting value.
@annevk I'm probably only thinking along these lines because of my inexperience
with the specification, but I know that same inexperience makes it easier for
me to stomach vocabulary changes like this. These details certainly have
momentum for folks who have been working in this space for a while. My bias
notwithstanding, I do think this would make the text easier to follow. Other
alternatives that would address my concern are "scheme fetch" or "scheme-based
fetch", though those may be too technical/wordy.
Preview | Diff