Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Advise Vary even for non-CORS-request responses #564

Merged
merged 3 commits into from Jul 19, 2017
Merged

Advise Vary even for non-CORS-request responses #564

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b98d51b
Advise `Vary` even for non-CORS-request responses
sideshowbarker Jul 14, 2017
5e33292
fixup! Advise `Vary` even for non-CORS-request responses
sideshowbarker Jul 15, 2017
6d74cb5
fixup! Advise `Vary` even for non-CORS-request responses
sideshowbarker Jul 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions fetch.bs
View file
Open in desktop
Expand Up @@ -5679,6 +5679,11 @@ the user agent to <a for=/>fetch</a> a response that includes
from the previous non-<a>CORS request</a> that lacks
`<a http-header><code>Access-Control-Allow-Origin</code></a>`.

<p>However, if `<a http-header><code>Access-Control-Allow-Origin</code></a>` is set to
<code>*</code> or a static <a for=/>origin</a> for a particular resource, then configure the server
to always send `<a http-header><code>Access-Control-Allow-Origin</code></a>` in responses for the
resource — for non-<a lt="CORS request">CORS requests</a> as well as <a lt="CORS request">CORS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for the lt attribute here. Bikeshed knows about English plural.

requests</a> — and do not use `<code>Vary</code>`.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra newline here.

<h2 id=acknowledgments class=no-num>Acknowledgments</h2>

Expand Down