Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

queryPermission being used in WPT tests #42

Closed
jesup opened this issue Aug 2, 2022 · 0 comments
Closed

queryPermission being used in WPT tests #42

jesup opened this issue Aug 2, 2022 · 0 comments
Labels
needs tests Moving the issue forward requires someone to write tests

Comments

@jesup
Copy link
Contributor

jesup commented Aug 2, 2022

WPT tests for messaging use queryPermission(); this isn't defined here. It's in https://wicg.github.io/file-system-access/#api-filesystemhandle-querypermission

The OPFS tests shouldn't be using queryPermission, I believe
@annevk annevk added the needs tests Moving the issue forward requires someone to write tests label Sep 10, 2022
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Sep 29, 2022
@dslee414 @chromium-wpt-export-bot
Remove queryPermission() usage from wpt/fs helper function.
294b2ea 
Permission is not required in OPFS.
whatwg/fs#42

Bug: 1362626
Change-Id: I2c75c0374c9f5a9c323a03950f7bd3bdd4a93750
Merged
aarongable pushed a commit to chromium/chromium that referenced this issue Oct 3, 2022
@dslee414
Remove queryPermission() usage from wpt/fs helper function.
0bf44be 
Permission is not required in OPFS.
whatwg/fs#42

Bug: 1362626
Change-Id: I2c75c0374c9f5a9c323a03950f7bd3bdd4a93750
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3923838
Commit-Queue: Daseul Lee <dslee@chromium.org>
Reviewed-by: Austin Sullivan <asully@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1054413}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Oct 3, 2022
@dslee414 @chromium-wpt-export-bot
Remove queryPermission() usage from wpt/fs helper function.
3a64a7f 
Permission is not required in OPFS.
whatwg/fs#42

Bug: 1362626
Change-Id: I2c75c0374c9f5a9c323a03950f7bd3bdd4a93750
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3923838
Commit-Queue: Daseul Lee <dslee@chromium.org>
Reviewed-by: Austin Sullivan <asully@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1054413}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Oct 3, 2022
@dslee414 @chromium-wpt-export-bot
Remove queryPermission() usage from wpt/fs helper function.
9903e1a 
Permission is not required in OPFS.
whatwg/fs#42

Bug: 1362626
Change-Id: I2c75c0374c9f5a9c323a03950f7bd3bdd4a93750
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3923838
Commit-Queue: Daseul Lee <dslee@chromium.org>
Reviewed-by: Austin Sullivan <asully@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1054413}
@a-sully a-sully closed this as completed Oct 4, 2022
mjfroman pushed a commit to mjfroman/moz-libwebrtc-third-party that referenced this issue Oct 14, 2022
@dslee414
Remove queryPermission() usage from wpt/fs helper function.
d9e8809 
Permission is not required in OPFS.
whatwg/fs#42

Bug: 1362626
Change-Id: I2c75c0374c9f5a9c323a03950f7bd3bdd4a93750
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3923838
Commit-Queue: Daseul Lee <dslee@chromium.org>
Reviewed-by: Austin Sullivan <asully@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1054413}
NOKEYCHECK=True
GitOrigin-RevId: 0bf44bedae0269f846e98d8946fe7fbbaa9682a5
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Oct 21, 2022
@dslee414 @moz-wptsync-bot
Bug 1793524 [wpt PR 36170] - Remove queryPermission() usage from wpt/…
4c54352 
…fs helper function., a=testonly

Automatic update from web-platform-tests
Remove queryPermission() usage from wpt/fs helper function.

Permission is not required in OPFS.
whatwg/fs#42

Bug: 1362626
Change-Id: I2c75c0374c9f5a9c323a03950f7bd3bdd4a93750
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3923838
Commit-Queue: Daseul Lee <dslee@chromium.org>
Reviewed-by: Austin Sullivan <asully@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1054413}

--

wpt-commits: 9903e1acb8d6215c058f36523d936fa6f5487796
wpt-pr: 36170
jamienicol pushed a commit to jamienicol/gecko that referenced this issue Oct 26, 2022
@dslee414 @moz-wptsync-bot
Bug 1793524 [wpt PR 36170] - Remove queryPermission() usage from wpt/…
dac2f4e 
…fs helper function., a=testonly

Automatic update from web-platform-tests
Remove queryPermission() usage from wpt/fs helper function.

Permission is not required in OPFS.
whatwg/fs#42

Bug: 1362626
Change-Id: I2c75c0374c9f5a9c323a03950f7bd3bdd4a93750
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3923838
Commit-Queue: Daseul Lee <dslee@chromium.org>
Reviewed-by: Austin Sullivan <asully@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1054413}

--

wpt-commits: 9903e1acb8d6215c058f36523d936fa6f5487796
wpt-pr: 36170
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs tests Moving the issue forward requires someone to write tests
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jesup @annevk @a-sully