Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with the "unloading document cleanup steps" #82

Open
foolip opened this issue May 11, 2017 · 4 comments
Open

Problems with the "unloading document cleanup steps" #82

foolip opened this issue May 11, 2017 · 4 comments

Comments

@foolip
Copy link
Member

foolip commented May 11, 2017

The spec currently says says "Whenever the unloading document cleanup steps run with a document, fully exit fullscreen document."

Working on #65, I wrote web-platform-tests/wpt#5887 which was supposed to test this and passes in Firefox, but I've realized there are at least these problems:

  • The exit fullscreen algorithm does nothing if the document is not fully active. Is a document fully active when unload a document runs? @annevk?
  • If the exit fullscreen algorithm did run as usual, part of it is async after the resize, and event should then be fired. They aren't in Firefox, and I don't think it'd make sense to fire events.

It's tempting to just use unfullscreen a document, but when the top-level browsing context is navigated something has to "resize topLevelDoc’s viewport to its "normal" dimensions" and that's currently a part of the exit fullscreen algorithm.

@annevk
Copy link
Member

annevk commented May 11, 2017

I think it's still active while unload a document runs, yes, but that's also one of the less clear areas of the HTML specification I hope to refactor.

@foolip
Copy link
Member Author

foolip commented May 11, 2017

OK, that isn't totally surprising, but I assume that it will become not active shortly after and that at least firing events on it isn't actually something we want. (Even more weird would be if the events are queued and then arrive if the document becomes active again.)

@annevk
Copy link
Member

annevk commented May 11, 2017

Yeah, if we needed to dispatch any events there they'd have to be carefully vetted I think. Even though fullscreen is a special state, it still shouldn't make it harder to navigate and such I think.

@foolip
Copy link
Member Author

foolip commented Dec 15, 2020

There are some tests to revive in web-platform-tests/wpt#5887 if I get back to fixing this spec issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants