-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert to Bikeshed #49
Conversation
Oh right, this doesn't rewrap anything, I think it makes sense to do that at the same time, WDYT? |
<script id=head src=https://resources.whatwg.org/dfn.js defer></script> | ||
|
||
<pre class=anchors> | ||
urlPrefix: https://dom.spec.whatwg.org/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since DOM is in bikeshed, we should not need this I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks some things can be used without this block, like "node document". I'll trim it down to just the ones that don't work without this.
Rewrap would be nice. Also, an initial commit that does the renames of Overview.src.html to fullscreen.bs and Overview.html to fullscreen.html would be good (and does no other changes). That way there's less to remove and more git blame. |
I've rewritten the history to do the rename first, net changes are the same. |
Ready for proper review now. |
@@ -534,18 +582,18 @@ user. | |||
<code>top</code> is zero. | |||
</ul> | |||
|
|||
<p>To <dfn>add</dfn> an <var>element</var> to a | |||
<p>To <dfn id=concept-top-layer-add>add</dfn> an <var>element</var> to a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should probably have for="top layer"
too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's not enough to remove the need for the id, and also isn't needed to disambiguate. Is it so that HTML could link to this if it used Bikeshed? No other specs use top layer.
We should probably also add |
I'll export the terms used by HTML, are there any others you think are needed? |
Well, HTML says "When an element is added to the pending dialog stack, it must also be added to the top layer. When an element is removed from the pending dialog stack, it must be removed from the top layer." without using Fullscreen's (new) add/remove definitions. How about exporting only add/remove and treating top layer itself as an internal concept? |
Strike that, the concept itself needs to be exposed in order to say "document's top layer". |
Comments addressed, added for="top layer" too just in case. |
convert.html is a one-off tool written for the purpose: https://gist.github.com/foolip/f60a1614fb5d194aad4dbff89c54ceb3
This was used to compare IDs and links to the current spec: for (var e of document.querySelectorAll('*')) { if (e.id) console.log('id: ' + e.id); if (e.hasAttribute('href') && e.className != 'self-link') console.log('href: ' + e.getAttribute('href')); } Existing IDs/links affected: * #table-of-contents → #toc * #refsCSS → #biblio-css (and similar) * #anolis-references is gone The old and new spec were also copied into plaintext and compared to verify no accidental differences. The biggest differences are in the references section.
Now ready to commit, as a single commit with this message:
|
Optimized for review, when the sum of changes looks good I'll turn it into a single commit.