Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the docker build to stop using Apache #140

Closed
domenic opened this issue Dec 15, 2017 · 0 comments · Fixed by #142
Closed

Fix the docker build to stop using Apache #140

domenic opened this issue Dec 15, 2017 · 0 comments · Fixed by #142

Comments

@domenic
Copy link
Member

domenic commented Dec 15, 2017

If you use the --docker parameter to HTML build, it will build inside a Docker container then host the site using Apache. That will break after #139 and associated other PRs.

We should probably change it to use nginx, possibly with some copy of the config in misc-server.

This logic currently lives in https://github.com/whatwg/html-build/blob/master/Dockerfile. I use it every day as it's faster than using the web service and Wattsi doesn't work on Windows.
foolip added a commit that referenced this issue Dec 19, 2017
@foolip
Switch from Apache to nginx for build.sh --docker
e8fccda 
Fixes #140.

Note that none of the redirects from misc-server are included here,
and weren't before either, in particular /multipage/images/ won't
redirect to /images/. To fix this well the configuration should be
shared, which is a bit of work, and so it's left broken for now.
@foolip foolip mentioned this issue Dec 19, 2017
Merged
domenic pushed a commit that referenced this issue Dec 19, 2017
@foolip @domenic
Switch from Apache to nginx for build.sh --docker
a222dfb 
Fixes #140.

Note that none of the redirects from misc-server are included here,
and weren't before either, in particular /multipage/images/ won't
redirect to /images/. To fix this well the configuration should be
shared, which is a bit of work, and so it's left broken for now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch from Apache to nginx for build.sh --docker whatwg/html-build
1 participant
@domenic