Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting rid of the Perl libxml prerequisite #24

Closed
domenic opened this issue Sep 10, 2015 · 4 comments
Closed

Getting rid of the Perl libxml prerequisite #24

domenic opened this issue Sep 10, 2015 · 4 comments

Comments

@domenic
Copy link
Member

domenic commented Sep 10, 2015

I think this plan is good:

Add an endpoint to watti-server, called cldr.inc, which when pinged does the svn checkout of cldr and the .cldr-processor.pl step and returns the result. This will generally be fast except the very first time.

We then add a guard in the build script (not sure on how) so that if we find out XML::Parser is not installed, we skip the cldr checkout and the .cldr-processor.pl step, instead just downloading it from the server.

@sideshowbarker, anything I'm missing? Seems like it should work.

@sideshowbarker
Copy link
Contributor

SGTM

@annevk
Copy link
Member

annevk commented Sep 11, 2015

There's no XML parser we can assume being installed?

@sideshowbarker
Copy link
Contributor

There's no XML parser we can assume being installed?

Not for Perl. I am nearly certain of that.

I checked the other day, using this:

for version in $(corelist -v | grep 5); do corelist -v $version | grep -i XML ; done

The only results that finds are for some POD:: (doc-related) stuff.

But maybe @Hixie can confirm

@Hixie
Copy link
Member

Hixie commented Sep 12, 2015

I just used whatever Dreamhost had, I think.

Installing packages for Perl is pretty easy, FWIW.

foolip added a commit that referenced this issue Feb 4, 2016
This fixes part of #62 by moving the generation of the quotes
stylesheet, which is very slow, outside of the main build script.

This also removes the dependency on svn and XML::Parser for the main
build script.

Fixes #24
@foolip foolip closed this as completed in d1ae80a Feb 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants