Report correct line numbers for parse violations, Domenic's take #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
force-pushed
the
domenic/line-numbers
branch
2 times, most recently
from
99c29fd
to
1ac2b3b
Compare
|
Nice work—this looks great and I just tested it and found it’s working fine, though I needed to make some minor fixes. So I’ll post those as review comments and once those are resolved this LGTM to merge. |
|
Overall compared to what I had hacked up currently in #28 this is a big improvement in terms of being simpler while solving the original problem we set up to solve with this. So, iteration FTW |
domenic
force-pushed
the
domenic/line-numbers
branch
from
1ac2b3b
to
b1ed941
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sideshowbarker, this is kind of what I was thinking. What do you think?