-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix fetching module scripts with circular imports
As pointed out by @jonco3 in IRC, the current fetching logic will recurse infinitely if a module imports itself (directly or indirectly). This fixes that by keeping track of all ancestors being fetched and not re-fetching them. Also, the "fetch a module script tree" and "fetch a single module script" algorithms don't always complete with _new_ module scripts, if they end up getting their result from the module map. So this removes the word "new" in their preludes.
- Loading branch information
Showing
1 changed file
with
16 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters